On Thu, Jul 06, 2017 at 04:20:41PM +0300, Leonard Crestez wrote: > On newer imx SOCs accessing OCOTP directly is wrong because the ocotp > clock needs to be enabled first. Add a binding for accessing the same > values through the imx-ocotp nvmem driver using nvmem-cells. This is > similar to other thermal drivers. > > The old binding is preserved for compatibility and because it still > works fine on imx6qdl series chips. > > In theory this problem could be solved by adding a reference to the > OCOTP clock instead but it is better to hide such details in a specific > nvmem driver. > > Signed-off-by: Leonard Crestez <leonard.crestez@xxxxxxx> > --- > Documentation/devicetree/bindings/thermal/imx-thermal.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/imx-thermal.txt b/Documentation/devicetree/bindings/thermal/imx-thermal.txt > index 3c67bd5..2842a05 100644 > --- a/Documentation/devicetree/bindings/thermal/imx-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/imx-thermal.txt > @@ -7,9 +7,16 @@ Required properties: > is higher than panic threshold, system will auto reboot by SRC module. > - fsl,tempmon : phandle pointer to system controller that contains TEMPMON > control registers, e.g. ANATOP on imx6q. > + > +Properties for OCOTP access: > - fsl,tempmon-data : phandle pointer to fuse controller that contains TEMPMON > calibration data, e.g. OCOTP on imx6q. The details about calibration data > can be found in SoC Reference Manual. > +Alternatively: Just put these under required props and put the deprecated one under a deprecated section. IOW, make it easy to remove the deprecated part. > +- nvmem-cells: A phandle to the calibration cells provided by ocotp. > +- nvmem-cell-names: Should be "calib", "temp_grade". > + > +Direct access to OCOTP is deprecated, please use nvmem cells instead. > > Optional properties: > - clocks : thermal sensor's clock source. > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
