Hello Geert, > From: geert.uytterhoeven@xxxxxxxxx > [mailto:geert.uytterhoeven@xxxxxxxxx] On Behalf Of Geert Uytterhoeven > Sent: 05 July 2017 15:56 > > Hi Chris, > > On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson > <Chris.Paterson2@xxxxxxxxxxx> wrote: > >> From: geert.uytterhoeven@xxxxxxxxx > >> [mailto:geert.uytterhoeven@xxxxxxxxx] On Behalf Of Geert > Uytterhoeven > >> Sent: 05 July 2017 14:47 > >> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> > wrote: > >> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. > >> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the > >> > R-Car > >> > Gen2 family. > >> > > >> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > >> > Reviewed-by: Chris Paterson <chris.paterson2@xxxxxxxxxxx> > >> > >> Thanks for your patch! > >> > >> > --- a/drivers/net/ethernet/renesas/ravb_main.c > >> > +++ b/drivers/net/ethernet/renesas/ravb_main.c > >> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct > >> > ravb_private > >> > *priv) } > >> > > >> > static const struct of_device_id ravb_match_table[] = { > >> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void > >> > + *)RCAR_GEN2 }, > >> > { .compatible = "renesas,etheravb-r8a7790", .data = (void > >> *)RCAR_GEN2 }, > >> > { .compatible = "renesas,etheravb-r8a7794", .data = (void > >> *)RCAR_GEN2 }, > >> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void > >> > *)RCAR_GEN2 }, > >> > >> As Sergei already mentioned, a driver update is not needed due to the > >> presence of family-specific compatible values. > >> Please drop that part, and you can add my: > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > Should the other compatible values (r8a7790, 94 etc) be removed then? Or > are they needed for backwards compatibility? > > The other compatible values in DT bindings and DTS files should be kept, to > allow handling of SoC-specific quirks if/when they are ever detected. > > The other compatible values in the driver should be kept for backwards- > compatibility with old DTB files that lack the (newer) family-specific > compatible values. Thank you for the comprehensive answer. Kind regards, Chris > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
