Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Biju,

On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2
> family.
>
> Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> Reviewed-by: Chris Paterson <chris.paterson2@xxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv)
>  }
>
>  static const struct of_device_id ravb_match_table[] = {
> +       { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 },
>         { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
>         { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
>         { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },

As Sergei already mentioned, a driver update is not needed due to the
presence of family-specific compatible values.
Please drop that part, and you can add my:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux