On Thu, Jun 29, 2017 at 12:45:51PM +0800, Ziping Chen wrote: > 2017-06-28 1:36 GMT+08:00 Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>: > > Hi, > > > > On Tue, Jun 27, 2017 at 11:29:10PM +0800, icenowy@xxxxxxx wrote: > >> Maxime, here's another problem: if we have already a GP LRADC driver, > >> how can we tell the kernel to use it as IIO ADC rather than keys? > > > > The GPADC IIO driver is not for the LRADC driver, but the GPADC / > > temperature sensor. > > > > We used to have an LRADC IIO driver in the CHIP BSP written by Alex > > (in CC): > > https://github.com/NextThingCo/CHIP-linux/commit/8675b761c54be73dc7cc0113209f02e10cc63a27 > > > > But he never mainlined it. > > > >> Should we introduce a new property for this once ready? > > > > We need to keep the current binding. We can just check for the > > presence or not of child nodes to see if it has some keys, and we'd > > need an IIO-to-input driver that is yet to be written. > > > > Yes, then we need an iio-to-input driver... > So...whether the driver(a83t lradc keys) can be applied now, > or we should wait for the iio-to-input driver. This is a long term discussion, it shouldn't hold the patches you sent. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature