2017-06-27 1:15 GMT+08:00 Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>: > Hi, > > On Sat, Jun 24, 2017 at 10:45:14AM +0800, Ziping Chen wrote: >> From: Ziping Chen <techping.chan@xxxxxxxxx> >> >> Allwinner A83T SoC has a low res adc like the one >> in Allwinner A10 SoC. >> >> Add binding for it. >> >> Signed-off-by: Ziping Chen <techping.chan@xxxxxxxxx> >> Acked-by: Rob Herring <robh@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt >> index 4357e498ef04..525d85e3043f 100644 >> --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt >> +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt >> @@ -2,12 +2,14 @@ Allwinner sun4i low res adc attached tablet keys >> ------------------------------------------------ >> >> Required properties: >> - - compatible: "allwinner,sun4i-a10-lradc-keys" >> + - compatible: should be one of the following string: >> + "allwinner,sun4i-a10-lradc-keys" >> + "allwinner,sun8i-a83t-r-lradc-keys" > > This doesn't really have anything related to keys, and can be used > purely as an ADC. > > I know this is the compatible that was used for the A10, but I'd > rather drop the keys for the the new compatible. > Hi, LRADC is named KEYADC in some other SoCs' User Manual(such as R40 User Manual V1.0), thus LRADC is related to keys. Without keys there is another driver named sun4i-gpadc-iio which is located at driver/iio/adc/sun4i-gpadc-iio.c Is my understanding right? > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
