On 20 June 2017 at 09:31, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > On 06/18, Chunyan Zhang wrote: >> diff --git a/drivers/clk/sprd/Makefile b/drivers/clk/sprd/Makefile >> index 8f802b2..333e2b2 100644 >> --- a/drivers/clk/sprd/Makefile >> +++ b/drivers/clk/sprd/Makefile >> @@ -1,3 +1,3 @@ >> ifneq ($(CONFIG_OF),) >> -obj-y += ccu_common.o >> +obj-y += ccu_common.o ccu_gate.o > > Can this be built as a module? Since most of all Spreadtrum device drivers would depend on if clocks have been initialized, so we'd prefer to build this into the kernel image. > >> endif >> diff --git a/drivers/clk/sprd/ccu_gate.c b/drivers/clk/sprd/ccu_gate.c >> new file mode 100644 >> index 0000000..3d27615 >> --- /dev/null >> +++ b/drivers/clk/sprd/ccu_gate.c >> @@ -0,0 +1,102 @@ >> +/* >> + * Spreadtrum gate clock driver >> + * >> + * Copyright (C) 2017 Spreadtrum, Inc. >> + * >> + * SPDX-License-Identifier: GPL-2.0 >> + */ >> + >> +#include <linux/clk-provider.h> >> + >> +#include "ccu_gate.h" >> + >> +DEFINE_SPINLOCK(gate_lock); > > This variable name is not very unique for debugging lockdep > reports. Probably needs 'sprd' in the name. Ok. Thank you for your comments, Chunyan > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
