On Thu, Jun 15, 2017 at 7:50 AM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote: > On Wed, Jun 14, 2017 at 08:17:04PM +0530, Jagan Teki wrote: >> On Fri, Apr 7, 2017 at 6:46 PM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote: >> > On Thu, Apr 06, 2017 at 11:32:07PM +0530, Jagan Teki wrote: >> >> From: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> >> >> >> >> Add support for Sound card and related codec(via i2c1) nodes >> >> on Engicam Is.IoT MX6UL variant module boards. >> >> >> >> Cc: Shawn Guo <shawnguo@xxxxxxxxxx> >> >> Cc: Matteo Lisi <matteo.lisi@xxxxxxxxxxx> >> >> Cc: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> >> >> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> >> >> --- >> >> Changes for v3: >> >> - Replace fsl,imx-audio-sgtl5000 and use simple-audio-card >> >> Changes for v2: >> >> - Use proper [label:] node-name[@unit-address] for codec >> >> - Remove incorrect codec property 'wlf,shared-lrclk' >> >> - Remove 'gpr' from sound card node >> >> >> >> arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 10 +++++++ >> >> arch/arm/boot/dts/imx6ul-isiot.dtsi | 44 ++++++++++++++++++++++++++++++ >> > >> > Can you help me understand how these two files are related? Why is >> > sgtl5000 added into one and sound node added into the other? >> >> lcdif, ts and sound card which may differ based on the base-board >> connected with SOM, So I moved these stuff which are related to >> Starter kit supported once's and used with SOM dts files. if some >> other board with same SOM can have different lcdif and etc so they can >> define locally to dts. > > I do not follow how these stuff are organized. So far we have the > following isiot dts files. > > - imx6ul-isiot-common.dtsi > - imx6ul-isiot.dtsi > - imx6ul-isiot-emmc.dts and imx6ul-isiot-nand.dts > > How are they mapping to SoM and base-board? isiot is a modules class, with that emmc and nand are two separate SOM's. the current support is for mounting these SOM's on Development base board[1]. So, for isiot module class we have imx6ul-isiot.dtsi and emmc and nand SOM's have imx6ul-isiot-emmc.dts and imx6ul-isiot-nand.dts. There are some Carrier boards[1] which were used with different lcdif and other changes, So imx6ul-isiot-common.dtsi have changes common across emmc and nand, instead of adding them into individual dts files I moved in -common.dtsi. So in future if isiot SOM mounted on carrier board which should have a separate dts and which may or may not use imx6ul-isiot-common.dtsi [1] https://www.engicam.com/vis-prod/101142 [2] https://www.engicam.com/vis-prod/101128 thanks! -- Jagan Teki Senior Linux Kernel Engineer | Amarula Solutions U-Boot, Linux | Upstream Maintainer Hyderabad, India. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
