On Wed, May 31, 2017 at 03:30:26PM +0200, Marc Gonzalez wrote: > Binding for the Sigma Designs SMP8759 SoC. > > Signed-off-by: Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/pci/tango-pcie.txt | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/tango-pcie.txt b/Documentation/devicetree/bindings/pci/tango-pcie.txt > new file mode 100644 > index 000000000000..35ef2c811a27 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/tango-pcie.txt > @@ -0,0 +1,30 @@ > +Sigma Designs Tango PCIe controller > + > +Required properties: > + > +- compatible: "sigma,smp8759-pcie" > +- reg: address/size of PCI configuration space, address/size of register area > +- device_type: "pci" > +- #size-cells: <2> > +- #address-cells: <3> > +- msi-controller > +- ranges: translation from system to bus addresses > +- interrupts: spec for misc interrupts, spec for MSI > + > +http://elinux.org/Device_Tree_Usage#PCI_Address_Translation > +http://elinux.org/Device_Tree_Usage#Advanced_Interrupt_Mapping Why are these here? There's several standard properties you are missing like bus-range. Build your dts with "W=2". dtc recently gained some checks for PCI bindings. > + > +Example: > + > + pcie@2e000 { > + compatible = "sigma,smp8759-pcie"; > + reg = <0x50000000 SZ_4M>, <0x2e000 0x100>; > + device_type = "pci"; > + #size-cells = <2>; > + #address-cells = <3>; > + msi-controller; > + ranges = <0x02000000 0x0 0x00400000 0x50400000 0x0 SZ_60M>; I don't think SZ_60M exists or is available to dts files. Just put the number in. > + interrupts = > + <54 IRQ_TYPE_LEVEL_HIGH>, /* misc interrupts */ > + <55 IRQ_TYPE_LEVEL_HIGH>; /* MSI */ > + }; > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
