On Fri, Jan 10, 2014 at 10:37:01AM -0800, Olof Johansson wrote: > > On a side note, I'm not really a fan of this pattern: > > > > #define FOO1 1 2 3 > > > > #define BAR FOO1 FOO2 FOO3 > > > > While it definitely simplifies the dts files, it would never be used > > in C and obfuscates what the actual property size is. Reading a dts > > file, I would naturally assume the define was a single value while in > > fact it could expand to a very large property size. > > Hmm. Shawn? What I read from Rob is that he does not like it but he does not hate it so much either. And that's probably why I did not get either ACK or NACK from him when the usage was firstly introduced :) While I agree such macro usage should be avoided or limited, it really helps IMX pinctrl case to improve the readability and make the handwriting of these pinctrl entries less error prone. Isn't it the whole point of introducing macro support for DTC? Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
