Hi Andrey, no code review, just 2 drive-by comments. Am Dienstag, den 06.06.2017, 11:06 -0700 schrieb Andrey Smirnov: > Add a driver for RAVE Supervisory Processor, an MCU implementing > varoius bits of housekeeping functionality (watchdoging, backlight > control, LED control, etc) on RAVE family of products by Zodiac > Inflight Innovations. > > This driver implementes core MFD/serdev device as well as > communication subroutines necessary for commanding the device. > > Cc: cphealy@xxxxxxxxx > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Cc: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > --- [...] > +++ b/drivers/mfd/rave-sp.c > @@ -0,0 +1,1009 @@ > +/* > + * rave-sp.c - Multifunction core driver for Zodiac Inflight Innovations > + * SP MCU that is connected via dedicated UART port > + * > + * Copyright (C) 2017 Zodiac Inflight Innovations > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see <http://www.gnu.org/licenses/>. > + */ [...] > +MODULE_DEVICE_TABLE(of, rave_sp_dt_ids); > +MODULE_LICENSE("GPL"); Header says GPL v2, so this should be changed to match. [...] > + > +#define COMPATIBLE_RAVE_SP_NIU "zii,rave-sp-niu" > +#define COMPATIBLE_RAVE_SP_MEZZ "zii,rave-sp-mezz" > +#define COMPATIBLE_RAVE_SP_ESB "zii,rave-sp-esb" > +#define COMPATIBLE_RAVE_SP_RDU1 "zii,rave-sp-rdu1" > +#define COMPATIBLE_RAVE_SP_RDU2 "zii,rave-sp-rdu2" Can we get rid of those defines? They are only used in the of_device_id table. Regards, Lucas -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
