Re: [PATCH RFC 3/5] ARM: dts: at91-sama5d4: use IRQ_TYPE_* to specify irq flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 26/05/2017 at 21:17:37 +0200, Marek Vasut wrote:
> On 05/26/2017 08:06 PM, Uwe Kleine-König wrote:
> > According to the binding documentation and the source code the atmel-gpio
> > controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.
> > 
> > This patch uses the right variable type which yields the same result
> > when compiled. Note that this might be wrong and actually
> > IRQ_TYPE_LEVEL_LOW is intended by the dt author.
> > 
> > Signed-off-by: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
> > ---
> > Hello,
> > 
> > can somebody with the hardware or it's documentation please check which
> > flag is the right one?
> 
> It's correct, I tested the CAN, so:
> 
> Acked-by: Marek Vasut <marex@xxxxxxx>
> 
> > Best regards
> > Uwe
> > 
> >  arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux