On Tue, 30 May 2017 08:51:31 +0530 Keerthy <j-keerthy@xxxxxx> wrote: > > > On Tuesday 30 May 2017 08:17 AM, Kunihiko Hayashi wrote: > > Hi Keerthy, > > Thank you for your comment. > > > > On Mon, 29 May 2017 15:53:39 +0530 Keerthy <j-keerthy@xxxxxx> wrote: > >> > >> > >> On Monday 29 May 2017 02:45 PM, Kunihiko Hayashi wrote: > >>> Add a thermal driver for on-chip PVT (Process, Voltage and Temperature) > >>> monitoring unit implemented on UniPhier SoCs. This driver supports > >>> temperature monitoring and alert function. > >> > >> The Documentation in patch 2/4 should be squashed into this patch. > > > > According to the following guide, > > http://elixir.free-electrons.com/linux/latest/source/Documentation/devicetree/bindings/submitting-patches.txt > > > > 1) The Documentation/ portion of the patch should be a separate patch. > > > > I think it should be separated, how about that? > > Then you should reorder the series as we get the warning with checkpatch: > > WARNING: DT compatible string "socionext,uniphier-pxs2-thermal" appears > un-documented -- check ./Documentation/devicetree/bindings/ > #488: FILE: drivers/thermal/uniphier_thermal.c:367: > + .compatible = "socionext,uniphier-pxs2-thermal", > > WARNING: DT compatible string "socionext,uniphier-ld20-thermal" appears > un-documented -- check ./Documentation/devicetree/bindings/ > #492: FILE: drivers/thermal/uniphier_thermal.c:371: > + .compatible = "socionext,uniphier-ld20-thermal", > > When i apply the first patch. OK. I also confirmed the warning messages. I'll reorder the patches 1/4 and 2/4. Best Regards, Kunihiko Hayashi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
