Re: [PATCH] misc: ad525x_dpot_spi: Add device tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, May 26, 2017 at 8:17 PM, Roshni Shah <roshni.shah@xxxxxxxxxxx> wrote:
> @@ -81,14 +82,26 @@ static const struct ad_dpot_bus_ops bops = {

> +static const struct of_device_id ad_dpot_spi_of_match[] = {
> +       {
> +               .compatible     = "ad,ad5160",
> +               .name           = "ad5160",
> +               .data           = (void *)AD5160_ID,
> +       },
> +       {
> +               .compatible     = "ad,ad5161",
> +               .name           = "ad5161",
> +               .data           = (void *)AD5161_ID,
> +       },

You should only match on 'compatible', not on 'name'. By convention,
the name just describes what the device does.

      Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux