Am Mittwoch, 24. Mai 2017, 16:44:05 CEST schrieb Eddie Cai: > 2017-05-24 16:17 GMT+08:00 Heiko Stuebner <heiko@xxxxxxxxx>: > > Hi Eddie, > > > > Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai: > >> the previous setting of act8846 is just copy from firefly board. but > >> the reload board is a little different from firefly board. let's correct > >> it. > >> > >> Signed-off-by: Eddie Cai <eddie.cai.linux@xxxxxxxxx> > >> --- > >> arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++---------- > >> 1 file changed, 11 insertions(+), 10 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > >> index 8134966..4cfa109 100644 > >> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > >> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi > >> @@ -179,6 +179,7 @@ > >> regulator-name = "vccio_sd"; > >> regulator-min-microvolt = <3300000>; > >> regulator-max-microvolt = <3300000>; > >> + regulator-always-on; > > > > the rest below looks pretty straight forward, but why does vccio_sd > > need to be always on? > > > > I've checked the reload's schematics but did not find any further users > > of vccio_sd that may warant this attribute. > Oh, It's default on. thank you for point out my mistake. I will modify > it in next version. not default-on, but the mmc-core will turn on the vccio regulator on its own during probe. So yes, please fix :-) . Thanks Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
