Re: [PATCH v2 2/2] regulator: Allow for asymmetric settling times

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




El Sun, May 14, 2017 at 07:16:52PM +0900 Mark Brown ha dit:

> On Mon, May 01, 2017 at 11:37:15AM -0700, Matthias Kaehlcke wrote:
> 
> >  	else if (rdev->constraints->settling_time)
> >  		return rdev->constraints->settling_time;
> > +	else if (rdev->constraints->settling_time_up &&
> > +		 (new_uV > old_uV))
> > +		return rdev->constraints->settling_time_up;
> > +	else if (rdev->constraints->settling_time_down &&
> > +		 (new_uV < old_uV))
> > +		return rdev->constraints->settling_time_down;
> 
> It feels like we should warn if the user mixes specific up/down settling
> times with the more general property, can you please send a followup
> patch adding a warning for that?  It's not exactly obvious what the
> precedence is and may do the wrong thing with an older kernel or
> non-Linux OS.

Sounds good. I'll send out the patch soon.

Thanks

Matthias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux