On Thu, 2017-05-11 at 16:20 +0300, Jarkko Nikula wrote: > On 05/08/2017 07:53 PM, Andy Shevchenko wrote: > > > + } else if (reg == (DW_IC_COMP_TYPE_VALUE & 0x0000ffff)) { > > > > GENMASK(15, 0) > > > > I don't think this increase readability compared to 0x0000ffff here. If it's a defined constant it might do, otherwise I'm fine with explicit value. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html