Am 09.05.2017 um 22:27 schrieb Maxime Ripard:
> Hi Oleksij,
>
> It looks much better, thanks!
>
> On Sat, May 06, 2017 at 07:30:38AM +0200, Oleksij Rempel wrote:
>> This names the GPIO lines on the Banana Pi board in accordance with
>> the A20_Banana_Pi v1.4 Specification.
>>
>> This will make these line names reflect through to user space
>> so that they can easily be identified and used with the new
>> character device ABI.
>>
>> Signed-off-by: Oleksij Rempel <linux@xxxxxxxxxxxxxxxx>
>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> Cc: devicetree@xxxxxxxxxxxxxxx
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Cc: Chen-Yu Tsai <wens@xxxxxxxx>
>> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
>> ---
>
> Usually, it's better here if you put a change log with the things that
> changed from one version to another.
>
> You probably remember all of the comments that were made on the
> previous version of that patch, but I don't ;)
ok.
>
>> arch/arm/boot/dts/sun7i-a20-bananapi.dts | 51 ++++++++++++++++++++++++++++++++
>> 1 file changed, 51 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
>> index 91f2e5f..6b326b3 100644
>> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
>> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
>> @@ -178,6 +178,57 @@
>> };
>>
>> &pio {
>> + gpio-line-names =
>> + /* PA */
>> + "ERXD3", "ERXD2", "ERXD1", "ERXD0", "ETXD3",
>> + "ETXD2", "ETXD1", "ETXD0",
>> + "ERXCK", "ERXERR", "ERXDV", "EMDC", "EMDIO",
>> + "ETXEN", "ETXCK", "ECRS",
>> + "ECOL", "ETXERR", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + /* PB */
>> + "PMU-SCK", "PMU-SDA", "", "", "", "", "", "",
>> + "", "USB0-DRV", "", "", "", "", "", "",
>> + "", "", "", "", "SCL", "SDA", "", "",
>
> I'm not sure how it's called in the schematics / documentation, but
> having a way to get which bus it's from would be helpful (like you did
> for the PMIC I2C bus).
I use only names provided by schematics. Using something different IMO
makes no sense and confusing.
>> + "", "", "", "", "", "", "", "",
>> + /* PC */
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + /* PD */
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + /* PE */
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + /* PF */
>> + "SD0-D1", "SD0-D0", "SD0-CLK", "SD0-CMD", "SD0-D3",
>> + "SD0-D2", "", "",
>
> Why did you change the wrapping and indentation on those two lines?
i use 8 entry per line to keep counting easier. If line is too wide, i
wrap it with changed indentation.
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + /* PG */
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "", "",
>> + /* PH */
>> + "TXD0", "RXD0", "IO-1", "PH3", "USB0-IDDET", "PH5", "", "",
>
> What are PH3 and PH5 used for on the board? Can't we provide a more
> explicit name?
Only names used by schematic :) If we will use something different users
will hate us even more.
I can image to use some kind of combination of connector name and pin
name. For example: "JP1-RXD0", or some thing like this.
> Thanks!
> Maxime
>
--
Regards,
Oleksij
Attachment:
signature.asc
Description: OpenPGP digital signature
