On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote: > Add pin configuration subnode for ETHER ethernet controller. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> (...) > + pins_bidir { > + pinmux = <RZA1_PINMUX(3, 3, 2)>;/* P3_3 = ET_MDIO */ > + bi-directional; > + }; So I'm against merging this until someone explains what "bi-directional" actually means, electrically speaking. What happens physically on this pin? I think this just means open drain. It is dangerous to merge things we don't understand. Surely someone inside Renesas can answer this question. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html