Hi Linus,
On 04/24/2017 02:37 PM, Linus Walleij wrote:
On Fri, Apr 7, 2017 at 5:10 PM, Alexandre TORGUE
<alexandre.torgue@xxxxxx> wrote:
Add .get_direction() gpiochip callback in STM32 pinctrl driver.
Signed-off-by: Alexandre TORGUE <alexandre.torgue@xxxxxx>
(...)
+#include <linux/gpio.h>
No this is wrong, drivers should never include this file.
It is a deprecated consumer header.
+ if ((alt == 0) && (mode == 0))
+ ret = GPIOF_DIR_IN;
+ else if ((alt == 0) && (mode == 1))
+ ret = GPIOF_DIR_OUT;
Just return 0 or 1, that is the driver-internal API.
Ok. I will fix it in V2.
Thanks
Alex
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
