On Fri, Apr 14, 2017 at 8:49 AM, Dong Aisheng <dongas86@xxxxxxxxx> wrote: > On Fri, Apr 14, 2017 at 08:19:44AM -0700, Andrey Smirnov wrote: > ... >> >> + gpc: gpc@303a0000 { >> >> + compatible = "fsl,imx7d-gpc"; >> >> + reg = <0x303a0000 0x10000>; >> >> + interrupt-controller; >> >> + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>; >> >> + #interrupt-cells = <3>; >> >> + interrupt-parent = <&intc>; >> >> + #power-domain-cells = <1>; >> >> + >> >> + pgc { >> >> + #address-cells = <1>; >> >> + #size-cells = <0>; >> >> + >> >> + pgc_pcie_phy: pgc-pcie-phy-domain { >> > >> > The node name should be something generic and has a unit-address when >> > there is a 'reg' property in the node. >> > >> >> I'll change it to pgc-power-domain@0, let me know if you want >> something different. >> > > I think just power-domain@0 is ok. Fair enough. I'll do that. > And also better replace unit-address by macro. > Good point. Will do. Thanks, Andrey Smirnov -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html