On Thu, Apr 13, 2017 at 3:20 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote: > Hi Andrey, > > On Thu, Apr 13, 2017 at 10:32 AM, Andrey Smirnov > <andrew.smirnov@xxxxxxxxx> wrote: > >> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts >> index 5be01a1..e0ff276 100644 >> --- a/arch/arm/boot/dts/imx7d-sdb.dts >> +++ b/arch/arm/boot/dts/imx7d-sdb.dts >> @@ -52,6 +52,30 @@ >> reg = <0x80000000 0x80000000>; >> }; >> >> + spi4 { > > Here you use spi4 label... > >> + compatible = "spi-gpio"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_spi1>; > > and here spi1, which is a bit confusing. > Agreed. It is confusing, will fix in v2. >> + status = "okay"; >> + gpio-sck = <&gpio1 13 0>; >> + gpio-mosi = <&gpio1 9 0>; >> + cs-gpios = <&gpio1 12 0>; > > You could use GPIO_ACTIVE_HIGH flag for better readability. Missed that, will fix in v2. Thanks, Andrey Smirnov -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html