On Mon, Jan 06, 2014 at 04:12:35PM +0000, Thierry Reding wrote:
> On Wed, Jan 01, 2014 at 07:43:41AM +0400, Alexander Shiyan wrote:
> > Add a new driver for the PWM controllers on the CLPS711X platform
> > based on the PWM framework.
>
> I think you can drop the last part ("based on the PWM framework") of
> that sentence. Perhaps a good idea would be to mention some of the
> peculiarities of this controller (supports two channels, only 4 bits
> specifying the duty-cycle, fixed period, ...).
>
> > diff --git a/Documentation/devicetree/bindings/pwm/cirrus-clps711x-pwm.txt b/Documentation/devicetree/bindings/pwm/cirrus-clps711x-pwm.txt
> > new file mode 100644
> > index 0000000..4caf819
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/cirrus-clps711x-pwm.txt
> > @@ -0,0 +1,16 @@
> > +* Cirris Logic CLPS711X PWM controller
> > +
> > +Required properties:
> > +- compatible: Should be "cirrus,clps711x-pwm".
> > +- reg: Physical base address and length of the controller's registers.
> > +- clocks: Phandle to the PWM source clock.
>
> "phandle"
plus clock-specifier.
>
> > +- #pwm-cells: Should be 1. See pwm.txt in this directory for a description of
> > + the cells format.
>
> Perhaps in this case it would be easier to simply mention that the cell
> specifies the index of the channel. pwm.txt isn't explicit about what a
> specifier of size 1 looks like (although it is sort of implied).
Yes please.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
