Re: [PATCH] of: introduces helper to manage optional property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, Dec 26, 2013 at 05:18:35AM +0000, Xiubo Li wrote:
> Gets to know whether one optional property is present or not in one
> device node. Returns true if the property is present, false otherwise.
> 
> There is one similar helper of_property_read_bool(), but it means that
> the property is one boolen type. For many drivers, they need to know
> whether one optional property is present or not firstly. Though many
> other of_XX helper can do this before deal with it's real work, there
> maybe other errors the driver need to deal with, and the errors maybe
> the same with the property absent error. And this helper can make the
> code briefer,more readable and easier to deal with.
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx>
> ---
>  include/linux/of.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 276c546..0bd8cb9 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -601,6 +601,23 @@ static inline int of_property_read_u32(const struct device_node *np,
>  	return of_property_read_u32_array(np, propname, out_value, 1);
>  }
>  
> +/**
> + * of_property_optional - Find one optional property

If we really do need something like this, it would be better named
of_property_present (and can alias of_property_read_bool internally).

Is there a particular case this would make easier? Do you have a real
example?

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux