On Sat, Apr 8, 2017 at 3:45 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote: > Thierry/Rob, > > On Tue, Feb 7, 2017 at 10:48 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote: >> On Tue, Feb 7, 2017 at 9:36 PM, Rob Herring <robh@xxxxxxxxxx> wrote: >> >>> Except I have no way of knowing whether: a) you omitted a supply >>> because you don't (yet) care, b) the panel has a single supply and you >>> are using power-supply or c) the panel has multiple supplies and your >>> binding is wrong. >>> >>> I can only eliminate A if you list the supplies. Just need something >>> like "power-supply : see simple-panel.txt". I've still got to go read >>> the panel spec if I really want to check the binding. >> >> Just checked the panel datasheet at >> http://www.glyn.de/data/glyn/media/doc/43wvf1g-0.pdf and it lists two >> supplies: >> DVDD (Digital power supply) and AVDD (Analog power supply). >> >> Our dts was just providing a single 'power-supply' which referred to a >> GPIO enabled regulator that drives DVDD. >> >> So it seems we missed to pass AVDD (not software controlled in our >> case, but we need to describe it in dts anyway). >> >> Does this mean we cannot use simple-panel for this particular panel >> and we should add a separate driver for it? > > Please confirm if we need to create a separate driver for this panel, thanks. The binding should list both. They can be optional though. Maybe you can parameterize the supply name in the driver for the single (controlled) supply case. Or provide power on/off hooks. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
