On 10/04/17 17:33, Russell King - ARM Linux wrote: > On Mon, Apr 10, 2017 at 03:02:14PM +0100, Juri Lelli wrote: > > Hi, > > > > On 10/04/17 14:51, Russell King - ARM Linux wrote: > > > On Mon, Mar 27, 2017 at 02:18:22PM +0100, Juri Lelli wrote: > > > > Printing out an error message when we failed to get the cpu device is > > > > not helping anyone. Remove it. > > > > > > (1) the subject line talks about removing a "comment" but you're > > > actually removing an error printk > > > (2) I don't think it's "not helping anyone", although the description > > > above doesn't say _why_ - it's reporting the lack of a missing CPU > > > device that we expect to be present. If it's not present, then > > > we're not going to end up with the cpu capacity attribute, and the > > > error message answers the "why is that sysfs file missing" question. > > > > That's the same I was thinking when I put the error message there in the > > first place. But, then Greg didn't seem to like it. > > I don't think it was a case of "not liking it" - Greg asked what use it > was. Greg also pointed out the race with userspace. > Right. I asked him for more information, since I wasn't able to understand where the problem is. > I think dropping this patch is the quickest way to move forward. > OK, I'm also up for dropping it. Best, - Juri -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
