Hi,
On 10/04/17 14:51, Russell King - ARM Linux wrote:
> On Mon, Mar 27, 2017 at 02:18:22PM +0100, Juri Lelli wrote:
> > Printing out an error message when we failed to get the cpu device is
> > not helping anyone. Remove it.
>
> (1) the subject line talks about removing a "comment" but you're
> actually removing an error printk
> (2) I don't think it's "not helping anyone", although the description
> above doesn't say _why_ - it's reporting the lack of a missing CPU
> device that we expect to be present. If it's not present, then
> we're not going to end up with the cpu capacity attribute, and the
> error message answers the "why is that sysfs file missing" question.
That's the same I was thinking when I put the error message there in the
first place. But, then Greg didn't seem to like it.
>
> I think a better commit message is needed for this change.
>
We could just skip this patch entirely. Or, of course, I can easily
update the commit message.
Which way is to be preferred?
Thanks,
- Juri
> >
> > Signed-off-by: Juri Lelli <juri.lelli@xxxxxxx>
> > ---
> > drivers/base/arch_topology.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> > index c33482121b7d..b24d9a2af2c5 100644
> > --- a/drivers/base/arch_topology.c
> > +++ b/drivers/base/arch_topology.c
> > @@ -81,11 +81,9 @@ static int register_cpu_capacity_sysctl(void)
> >
> > for_each_possible_cpu(i) {
> > cpu = get_cpu_device(i);
> > - if (!cpu) {
> > - pr_err("%s: too early to get CPU%d device!\n",
> > - __func__, i);
> > + if (!cpu)
> > continue;
> > - }
> > +
> > device_create_file(cpu, &dev_attr_cpu_capacity);
> > }
> >
> > --
> > 2.10.0
> >
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
