On Thu, Mar 30, 2017 at 05:44:29PM -0500, Rob Herring wrote: > On Fri, Mar 24, 2017 at 10:33:20AM -0500, Alan Tull wrote: > > From: Moritz Fischer <mdf@xxxxxxxxxx> > > Please use "dt-bindings: fpga: ..." for the subject. > > > > > > This adds the binding documentation for the Xilinx LogiCORE PR > > Decoupler soft core. > > > > Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx> > > Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> > > Acked-by: Alan Tull <atull@xxxxxxxxxx> > > I'm confused why you are sending these instead of Moritz? If it goes > through you, then it should have your S-o-B too. Do you want me to resend this Alan (with Rob's suggestions)? > > > Cc: Sören Brinkmann <soren.brinkmann@xxxxxxxxxx> > > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Cc: devicetree@xxxxxxxxxxxxxxx > > --- > > .../bindings/fpga/xilinx-pr-decoupler.txt | 35 ++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > > > > diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > > new file mode 100644 > > index 000000000000..2c527ac30398 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > > @@ -0,0 +1,35 @@ > > +Xilinx LogiCORE Partial Reconfig Decoupler Softcore > > + > > +The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more > > +decouplers / fpga bridges. > > +The controller can decouple/disable the bridges which prevents signal > > +changes from passing through the bridge. The controller can also > > +couple / enable the bridges which allows traffic to pass through the > > +bridge normally. > > + > > +The Driver supports only MMIO handling. A PR region can have multiple > > +PR Decouplers which can be handled independently or chained via decouple/ > > +decouple_status signals. > > + > > +Required properties: > > +- compatible : Should contain "xlnx,pr-decoupler-1.00" or "xlnx,pr-decoupler" > > I'd drop xlnx,pr-decoupler, but in any case, it should not be OR rather > "followed by". Plus the example has both. Michal wanted to have both, so I put both. Personally I don't care. I think they have some downstream stuff that relied on it. > > > +- regs : base address and size for decoupler module > > +- clocks : input clock to IP > > +- clock-names : should contain "aclk" > > + > > +Optional properties: > > +- bridge-enable : 0 if driver should disable bridge at startup > > + 1 if driver should enable bridge at startup > > + Default is to leave bridge in current state. > > + > > +See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings. > > + > > +Example: > > + fpga-bridge@100000450 { > > + compatible = "xlnx,pr-decoupler-1.00", > > + "xlnx-pr-decoupler"; > > + regs = <0x10000045 0x10>; > > + clocks = <&clkc 15>; > > + clock-names = "aclk"; > > + bridge-enable = <0>; > > + }; > > -- > > 2.11.0 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks, Moritz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html