Hello Rob, On 04/04/2017 12:54 PM, Rob Herring wrote: > On Tue, Apr 4, 2017 at 10:30 AM, Javier Martinez Canillas > <javier@xxxxxxxxxxxxxxx> wrote: >> There are Device Tree source files defining a device node for the >> retu/tahvo I2C chip, but there isn't a DT binding document for it. >> >> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> >> >> --- >> >> Changes in v4: >> - Use "dt-bindings: mfd:" prefix in subject line (Rob Herring). >> - Add information about what functions the device serve (Lee Jones). >> - Avoid using MFD in Device Tree (Lee Jones). >> >> Changes in v3: None >> Changes in v2: None >> >> Documentation/devicetree/bindings/mfd/retu.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/retu.txt b/Documentation/devicetree/bindings/mfd/retu.txt >> new file mode 100644 >> index 000000000000..7df21a2b28ea >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/retu.txt >> @@ -0,0 +1,21 @@ >> +* Device tree bindings for Nokia Retu and Tahvo multi-function device >> + >> +Retu and Tahvo are a multi-function devices found on Nokia Internet >> +Tablets (770, N800 and N810). The Retu chip provides watchdog timer >> +and power button control functionalities while Tahvo chip provides >> +USB transceiver functionality. >> + >> +Required properties: >> +- compatible: "nokia,retu" or "nokia,tahvo" >> +- reg: Specifies the I2C slave address of the ASIC chip > > Missing interrupts here. > Right, sorry for missing that. I'll wait for Lee's feedback before posting a new version in case I missed something else. > With that: > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > Thanks a lot for your review and acks! Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
