Hi Rob, On 2017/4/4 0:19, Rob Herring wrote: > ---------------------------------------------------------------------- > On Thu, Mar 30, 2017 at 05:22:58PM +0200, Gregory CLEMENT wrote: >> From: Hu Ziji <huziji@xxxxxxxxxxx> >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific properties. >> Also add properties for Xenon PHY setting. >> >> Signed-off-by: Hu Ziji <huziji@xxxxxxxxxxx> >> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt | 170 +++++++- >> 1 file changed, 170 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt > > I acked v6 and it seems like a minor change, though I had to search for > both because there is no revision history nor explanation why you didn't > add my ack. > Sorry for missing your ACK. I add a few but important comments on common Xenon power implementations in the examples. It is recorded in the cover letter. v6->v7: - Add comments on vqmmc and vmmc in examples in dt binding doc. I was a little unsure if we can still add your ACK after adding the comment. We will add your ACK back if we have to release another version later. Thank you. Best regards, Hu Ziji > Acked-by: Rob Herring <robh@xxxxxxxxxx> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html