On 4/3/2017 1:20 PM, Paul Cercueil wrote:
For a description of the pinctrl devicetree node, please read
Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.txt
For a description of the gpio devicetree nodes, please read
Documentation/devicetree/bindings/gpio/ingenic,gpio.txt
Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
[...]
diff --git a/arch/mips/boot/dts/ingenic/jz4740.dtsi
b/arch/mips/boot/dts/ingenic/jz4740.dtsi
index 3e1587f1f77a..9c23c877fc34 100644
--- a/arch/mips/boot/dts/ingenic/jz4740.dtsi
+++ b/arch/mips/boot/dts/ingenic/jz4740.dtsi
@@ -55,6 +55,67 @@
clock-names = "rtc";
};
+ pinctrl: ingenic-pinctrl@10010000 {
The node name should be generic, so please rename it to something
like "pin-controller@..."
OK.
+ compatible = "ingenic,jz4740-pinctrl";
+ reg = <0x10010000 0x400>;
+
+ gpa: gpio-controller@0 {
The name should be just "gpio@0", according to ePAPR and its
successor spec. Although, using the <unit-address> without the "reg"
prop isn't allowed either...
ePAPR says: "If the node has no reg property, the unit-address may be
My copy of ePAPR 1.1 says "must be omitted". :-)
omitted if the node name alone differentiates the node from other nodes at
the same level in the tree."
I could use 'gpio@bank-a', it is allowed by the spec. Or do you prefer 'gpio@0'?
Hm... maybe you should just use the "reg" prop.
I'll wait from some feedback on the other patches then send a v5.
Thanks,
-Paul
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
