On Fri, 31 Mar 2017 18:50:15 +0200 Andrew Lunn <andrew@xxxxxxx> wrote: > > - sata@a8000 { > > + satac0: sata@a8000 { > > Hi Ralph > > Why the c in satac0? For controller and to not conflict with a use case of sata0 for a port, similarly to pciec and pcie1. See armada-385-synology-ds116.dts. > > > > > - usb3@f0000 { > > + usb3_0: usb3@f0000 { > > compatible = > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 0x4000>; > > interrupts = <GIC_SPI 16 > > IRQ_TYPE_LEVEL_HIGH>; @@ -598,7 +598,7 @@ > > status = "disabled"; > > }; > > > > - usb3@f8000 { > > + usb3_1: usb3@f8000 { > > compatible = > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 0x4000>; > > interrupts = <GIC_SPI 17 > > IRQ_TYPE_LEVEL_HIGH>; > > I can understand what you are saying. But does anybody else care? Are > there other .dtsi files differentiating between USB 1.1, 2 and 3? It's handled differently where ever I looked, some do some don't. A case for distinguishing USB 2.0 and USB 3.0 like this is armada-388-gp.dts. Personally I'm only interested in there being a label, making it "natural" is a bonus though. Thanks Ralph > > Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html