> -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: Friday, March 24, 2017 8:26 AM > To: Ryans Lee <RyanS.Lee@xxxxxxxxxxxxxxxxxxx> > Cc: lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; mark.rutland@xxxxxxx; > perex@xxxxxxxx; tiwai@xxxxxxxx; kuninori.morimoto.gx@xxxxxxxxxxx; > arnd@xxxxxxxx; ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx; lars@xxxxxxxxxx; > bardliao@xxxxxxxxxxx; nh6z@xxxxxxxx; KCHSU0@xxxxxxxxxxx; > axel.lin@xxxxxxxxxx; romain.perier@xxxxxxxxxxxxx; petr@xxxxxxxxx; > srinivas.kandagatla@xxxxxxxxxx; oder_chiou@xxxxxxxxxxx; > Paul.Handrigan@xxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > dgreid@xxxxxxxxxx > Subject: Re: [PATCH] ASoC: Add support for Maxim Integrated MAX98927 > Amplifier > > EXTERNAL EMAIL > > > > On Mon, Mar 20, 2017 at 09:40:23AM +0900, Ryan Lee wrote: >> Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx> >> --- >> Resubmit the intial version of MAX98927 driver. Added all fixes into the initial patch. >> >> .../devicetree/bindings/sound/max98927.txt | 39 + >> sound/soc/codecs/Kconfig | 5 + >> sound/soc/codecs/Makefile | 2 + >> sound/soc/codecs/max98927.c | 1040 ++++++++++++++++++++ >> sound/soc/codecs/max98927.h | 267 +++++ >> 5 files changed, 1353 insertions(+) >> create mode 100755 >> Documentation/devicetree/bindings/sound/max98927.txt >> mode change 100644 => 100755 sound/soc/codecs/Kconfig mode change >> 100644 => 100755 sound/soc/codecs/Makefile create mode 100755 >> sound/soc/codecs/max98927.c create mode 100755 >> sound/soc/codecs/max98927.h >> >> diff --git a/Documentation/devicetree/bindings/sound/max98927.txt >> b/Documentation/devicetree/bindings/sound/max98927.txt >> new file mode 100755 >> index 0000000..d610879 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/max98927.txt >> @@ -0,0 +1,39 @@ >> +max98927 audio CODEC >> + >> +This device supports I2C. > > Can we combine this and the other max9892x bindings. They all look similar. They are not same but almost similar. I combined MAX98925, MAX98926 and MAX98927 bindings into MAX9892x.txt Thank you for your feedback. > >> + >> +Required properties: >> + >> + - compatible : "maxim,max98927" >> + >> + - maxim,vmon-slot-no : slot number used to send voltage >> + information > > While vendor prefix is preferred, so is using the same property names. > Either use the existing names or deprecate the old ones in favor of these. To use same property names, I kept existing names. Thanks. > >> + or in inteleave mode this will be used as >> + interleave slot. >> + This property can be set to values from 0 to 15 for slot 0 to 15. >> + Default value is 0. >> + >> + - maxim,imon-slot-no : slot number used to send current information >> + This property can be set to values from 0 to 15 for slot 0 to 15. >> + Default value is 0. >> + >> + - maxim,interleave-mode : When using two MAX98927 in a system it is >> + possible to create ADC data that that will >> + overflow the frame size. Digital Audio Interleave >> + mode provides a means to output VMON and IMON data >> + from two devices on a single DOUT line when running >> + smaller frames sizes such as 32 BCLKS per LRCLK or >> + 48 BCLKS per LRCLK. >> + This property can be set to values from 0 to 1 for off and on. >> + Default value is 0. >> + >> + - reg : the I2C address of the device for I2C >> + >> +Example: >> + >> +codec: max98927@3a { >> + compatible = "maxim,max98927"; >> + maxim,vmon-slot-no = <0>; >> + maxim,imon-slot-no = <1>; >> + maxim,interleave-mode = <0>; >> + reg = <0x3a>; >> +}; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
