On 28/03/17 15:55, Sudeep Holla wrote: > On 28/03/17 12:48, Jon Hunter wrote: >> Add the CPU and PSCI nodes for the NVIDIA Tegra210 platforms so that >> all CPUs can be enabled on boot. This assumes that the PSCI firmware >> has been loaded during the initial bootstrap on the device before the >> kernel starts (which is typically the case for these platforms). The >> PSCI firmware version is set to v0.2 which aligns with the current >> shipping version for Tegra. >> >> Reported-by: Martin Michlmayr <tbm@xxxxxxxxxx> >> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> >> --- >> arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 23 +++++++++++++++++++++++ >> arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi | 24 ++++++++++++++++++++++++ >> 2 files changed, 47 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi >> index 906fb836d241..de1696c28140 100644 >> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi >> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi >> @@ -296,6 +296,29 @@ >> }; >> }; >> >> + cpus { >> + cpu@0 { >> + enable-method = "psci"; > > Is some firmware expected to populate other required properties ? > > If yes, why not populate everything in the firmware ? > > If no, how does it even boot secondaries without the "reg" property > that usually contains MPIDR. Please see 'arch/arm64/boot/dts/nvidia/tegra210.dtsi' which has these fields. So far we have been populating the psci information at the board level and so I have kept with that here and so the above is just the delta. Maybe the $subject could be a little clearer! Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html