On 28 March 2017 09:37, Geert Uytterhoeven wrote: > Subject: Re: [PATCH V6 4/7] mfd: da9061: MFD core support > > Hi Lee, > > On Tue, Mar 28, 2017 at 10:21 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote: > >> [auto build test WARNING on ljones-mfd/for-mfd-next] > >> [also build test WARNING on v4.11-rc4 next-20170327] > >> base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next > >> config: x86_64-randconfig-x009-201713 (attached as .config) > >> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > >> reproduce: > >> # save the attached .config to linux build tree > >> make ARCH=x86_64 > >> > >> All warnings (new ones prefixed by >>): > >> > >> drivers//mfd/da9062-core.c: In function 'da9062_i2c_probe': > >> >> drivers//mfd/da9062-core.c:845:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > >> chip->chip_type = (int)match->data; > >> ^ > > > > Please use longs or enums. > > Enums would still give a warning on 64-bit. > The simple fix is change the cast from (int) to (uintptr_t). Hi Lee and Geert, How about this? Fix by redefining the enum chip_type to be an int. Then, just use substitution: #define COMPAT_TYPE_DA9061 1 #define COMPAT_TYPE_DA9062 2 That would be simple. Are there any reasons this would not be acceptable? Regards, Steve ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
