Hi Boris, 2017-03-23 6:35 GMT+09:00 Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>: > Hi Masahiro, > > On Thu, 23 Mar 2017 05:06:59 +0900 > Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: > >> It took a couple months to update this series, but finally here is v2. >> (v1: https://lkml.org/lkml/2016/11/26/144 ) >> >> This driver includes many problems. >> >> One of the biggest one is a bunch of hard-coded parameters. This IP >> has many parameters that can be customized when a delivery RTL is >> generated. However, this driver was upstreamed by Intel, with >> Intel parameters hard-coded. Later, Altera added denali_dt.c to use >> this driver for embedded boards, but they did not fix the code in >> denali.c So, this driver has never worked. Even some DT bindings >> actually turned out wrong. >> >> There are more problems: [1] The driver just retrieves the OOB area as-is >> whereas the controller uses syndrome page layout. [2] Many NAND chip >> specific parameters are hard-coded in the driver. [3] ONFi devices are >> not working [4] It can not read Bad Block Marker >> >> This patch series intends to solve those problems. >> >> Since v1, here are more fixes/improvements: >> - Fix raw/oob callbacks for syndrome page layout >> - Implement setup_data_interface() callback >> - Fix/implement more commands for ONFi devices >> - Allow to skip the driver internal bounce buffer >> - Support PIO in case DMA is not supported >> - Switch from ->cmdfunc over to ->cmd_ctrl > > I'll probably pick a few patches for 4.12, so please wait a bit before > sending a v4. This will be helpful. I was refused by the SMTP server I use (probably due to too much volume at once). Please check the following as well. >> mtd: nand: do not check R/B# for CMD_READID in nand_command(_lp) >> mtd: nand: do not check R/B# for CMD_SET_FEATURES in nand_command(_lp) I noticed them when I switched from ->cmdfunc to ->cmd_ctrl hook. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
