Hello Akshay, Am 16.03.2017 um 18:06 schrieb Akshay Bhat: > Hi Wolfgang, > > On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote: >> Hello Akshay, >> > ..snip.. >>> >>> So here is my plan: >>> - Have the bus error interrupt always enabled >>> - If berr-reporting off, then have the isr checks/reports state changes >> >> Error state change messages should always be there. These are the >> important one. >> >>> - if berr-reporting on, then have the isr checks/reports bus errors >>> and state changes (Does it make sense packing the error message, if >>> the ISR finds both bus and state changes?) >> >> If berr-reporting is off, simply do not create an error message for bus >> errors, and only if the state changed. If it's "on" create an additional >> bus error message. >> >> http://lxr.free-electrons.com/source/drivers/net/can/flexcan.c#L334 >> >> > > I have fixed the driver to handle the error reporting. Also thanks for > your tip for generating bus-off by setting the host device at a > different CAN bit rate! Below are logs with the updated driver. Let me > know if you have any concerns, if not I will submit the v4 patch. > > berr-reporting on case: > http://pastebin.com/qDRLERmW Looks much better now! There are message for state changes to error warning and passive. Just the following message is not correct: (000.200824) can0 20000004 [8] 00 40 00 00 00 00 5F 19 ERRORFRAME controller-problem{} error-counter-tx-rx{{95}{25}} Sorry, forgot to mention... the function can_change_state() [1] should be used for that purpose, if possible. It fixes the issue above as well. > berr-reporting off case: > http://pastebin.com/fUn3j7qU Ditto. I just had another look to the manual and there is this undocumented STATFE register at offset 0x1E. It's mentioned in some other parts of the doc as interrupt enable register for STATF events. I would assume the same bit layout than STATF. If you set bit 2 (BUSOFF), 3 (ERRP) and 4 (ERRW), you may get interrupts. It's worth a try, I think. If it works, it's the much better solution. Wolfgang. [1] http://lxr.free-electrons.com/ident?i=can_change_state Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
