Hi Wolfgang, On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote: > Hello Akshay, > ..snip.. >> >> So here is my plan: >> - Have the bus error interrupt always enabled >> - If berr-reporting off, then have the isr checks/reports state changes > > Error state change messages should always be there. These are the > important one. > >> - if berr-reporting on, then have the isr checks/reports bus errors >> and state changes (Does it make sense packing the error message, if >> the ISR finds both bus and state changes?) > > If berr-reporting is off, simply do not create an error message for bus > errors, and only if the state changed. If it's "on" create an additional > bus error message. > > http://lxr.free-electrons.com/source/drivers/net/can/flexcan.c#L334 > > I have fixed the driver to handle the error reporting. Also thanks for your tip for generating bus-off by setting the host device at a different CAN bit rate! Below are logs with the updated driver. Let me know if you have any concerns, if not I will submit the v4 patch. berr-reporting on case: http://pastebin.com/qDRLERmW berr-reporting off case: http://pastebin.com/fUn3j7qU Thanks, Akshay -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
