On Fri, Mar 10, 2017 at 5:20 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> On 03/10/2017 05:07 PM, Tim Harvey wrote:
>> On Fri, Mar 10, 2017 at 12:43 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
>>>
>>>> + dsa {
>>>> + compatible = "marvell,dsa";
>>>> + #address-cells = <2>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + dsa,ethernet = <&fec>;
>>>> + dsa,mii-bus = <&mdio>;
>>>> +
>>>
>>> Please consider using the new binding for DSA switches, see:
>>>
>>> https://patchwork.kernel.org/patch/9493037/
>>>
>>
>> Hi Florian,
>>
>> I tried the new binding first, but haven't gotten it to work yet. Let
>> me make sure I understand what I should be doing.
>>
>> This is a MV88E6176 so I first need to add dt support for that to the
>> mv88e6xxx driver (which supports the device, just not via dt):
>> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
>> index 03dc886..fd5c716 100644
>> --- a/drivers/net/dsa/mv88e6xxx/chip.c
>> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
>> @@ -4602,6 +4602,10 @@ static const struct of_device_id mv88e6xxx_of_match[] = {
>> .data = &mv88e6xxx_table[MV88E6085],
>> },
>> {
>> + .compatible = "marvell,mv88e6176",
>> + .data = &mv88e6xxx_table[MV88E6176],
>> + },
>> + {
>> .compatible = "marvell,mv88e6190",
>> .data = &mv88e6xxx_table[MV88E6190],
>> },
>>
>> Then I remove the old binding and add the new binding as such:
>>
>> &fec {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_enet>;
>> phy-mode = "rgmii-id";
>> status = "okay";
>
> You most likely need to declare a fixed PHY for the FEC to be setting up
> the link, speed and duplex?
Florian,
Thanks - this appears to be the issue. I declared the fixed-phy down
in the cpu port but I guess it needs to be done in the net device.
Tim
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
