Re: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Moritz,

On 10.3.2017 23:42, Moritz Fischer wrote:
> On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer <mdf@xxxxxxxxxx> wrote:
>> This adds support for the Xilinx LogiCORE PR Decoupler
>> soft-ip that does decoupling of PR regions in the FPGA
>> fabric during partial reconfiguration.
>>
>> Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>
>> Cc: Michal Simek <michal.simek@xxxxxxxxxx>
>> Cc: Sören Brinkmann <soren.brinkmann@xxxxxxxxxx>
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Cc: devicetree@xxxxxxxxxxxxxxx
>> ---
>>  drivers/fpga/Kconfig               |   9 +++
>>  drivers/fpga/Makefile              |   1 +
>>  drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++
>>  3 files changed, 166 insertions(+)
>>  create mode 100644 drivers/fpga/xilinx-pr-decoupler.c

I have written very similar driver some week ago but didn't sent it out.

Here it is.
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c

Your clk handling is better and my enable_show is better.
You shouldn't rely on setting status before. It is better to read that
reg again. The reason is you can connect status signal from one PR
decoupler to decouple input which can change status

There is another topic I wanted to open in connection to this. There
should be gpio based bridge because this pr decoupler can be without axi
interface and for that gpio driver would be useful.

Thanks,
Michal


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux