On Sun 05 Mar 05:01 GMT 2017, Jonathan Neusch?fer wrote: > On Fri, Mar 03, 2017 at 05:20:32PM -0800, Bjorn Andersson wrote: > > On Tue 14 Feb 20:51 PST 2017, Jonathan Neusch?fer wrote: > > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> > > > --- > > > arch/arm/configs/qcom_defconfig | 5 +++++ > > > 1 file changed, 5 insertions(+) > [...] > > > +CONFIG_QCOM_SMP2P=y > > > > We also need CONFIG_QCOM_SMSM=y here, its currently used to signal state > > of the ring buffers for WiFi. > > FWIW, I enabled CONFIG_QCOM_SMSM on my test system (an Asus Padfone, > based on MSM8974; I'm using the Sony Xperia Honami DT because it's close > enough), and I think it failed to initialize: > Using Honami should work so far, but please do write a patch adding the Padfone, so that we don't accidentally break your HW at some point. > [ 0.647743] qcom-smsm smsm: no smsm size info, using defaults > [ 0.647775] qcom-smsm smsm: unable to allocate shared state entry > Could you please confirm where in qcom_smem_alloc_global() we're failing? As far as I can tell we should fail with -EEXIST or if the passed "size" parameter is bogus -ENOMEM (but the default number of entries really should be less than the amount of free SMEM space). > I think CONFIG_QCOM_WCNSS_CTRL may be needed too, but I'll leave that > for a future patch because I don't understand WCNSS well enough. > Missed that one, when the WCNSS firmware boots the WCNSS_CTRL driver is probed - it will upload the NV parameter file to the WCNSS "OS" and when that is done it will probe the WiFi and BT drivers. So, you need it as well. > > With the addition of that you have my: > > > > Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > I'll send a v2 of this series with your R-b and A-b tags. > Thanks, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
