Hello,
On Thu, Dec 19, 2013 at 08:10:27PM +0100, Andrew Lunn wrote:
> > Shouldn't it distinguish between failures and at least produce
> > warning? ie. phy not available and phy init failed due to memory
> > pressure or whatnot shouldn't be handled the same.
>
> Phy not available is not an error, since not all variants of the SATA
^
always
> IP block have the ability to control the phy. I can however add a
> warning for real errors.
Yes, please.
> > > > @@ -4132,6 +4148,8 @@ err:
> > > > clk_disable_unprepare(hpriv->port_clks[port]);
> > > > clk_put(hpriv->port_clks[port]);
> > > > }
> > > > + if (!IS_ERR(hpriv->port_phys[port]))
> > > > + phy_power_off(hpriv->port_phys[port]);
> >
> > And I'd much prefer the array holds either NULL or valid pointer.
>
> I was trying to keep the code similar to the clk handling. However now
> that it is diverging more and more from how clk is handled, i can add
> yet more divergence and overwrite the error with a NULL.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
