On Tue, 21 Feb 2017 15:01:32 +0100
Michal Simek michal.simek@xxxxxxxxxx wrote:
...
>> +static struct spi_driver xilinx_slave_spi_driver = {
>> + .driver = {
>> + .name = "xlnx-slave-spi",
>> + .owner = THIS_MODULE,
>
>This should be done by core and it is checked by testing system.
Okay, will remove it.
...
>> +MODULE_LICENSE("GPL");
>
>Above you have GPL v2 and here v2 or later.
>
>include/linux/module.h
> * "GPL" [GNU Public License v2 or later]
> * "GPL v2" [GNU Public License v2]
>
>What's the license then?
should be "GPL v2", I'll fix it next patch version.
...
>> +MODULE_DESCRIPTION("Load Xilinx FPGA firmware over SPI");
>>
>
>What's the hw configuration?
I used Spartan-6 for testing. But the driver might work with other
Xilinx FPGAs, so I didn't add exact hw description.
Thanks for review and comments!
Anatolij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
