On 17 February 2017 at 12:13, Mike Leach <mike.leach@xxxxxxxxxx> wrote: > Juno platforms have a programmable replicator splitting the trace output to > TPIU and ETR. Currently this is not being programmed as it is being treated > as a none-programmable replicator - which is the default operational mode > for these devices. The TPIU in the system is enabled by default, and this > combination is causing back-pressure in the trace system resulting in > overflows at the source. > > Replaces the existing definition with one that defines the programmable > replicator, using the "qcom,coresight-replicator1x" driver that provides > the correct functionality for CoreSight programmable replicators. > > Signed-off-by: Mike Leach <mike.leach@xxxxxxxxxx> > --- > arch/arm64/boot/dts/arm/juno-base.dtsi | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index 9d799d9..6546e23 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -372,12 +372,14 @@ > }; > }; > > - coresight-replicator { > - /* > - * Non-configurable replicators don't show up on the > - * AMBA bus. As such no need to add "arm,primecell". > - */ > - compatible = "arm,coresight-replicator"; > + coresight-replicator@20120000 { > + There is an extra line that is not needed here. And we can probably change "coresight-replicator" to "replicator" now that it can be discovered on the AMBA bus. Other than that: Tested-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> Reviewed-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> > + compatible = "qcom,coresight-replicator1x", "arm,primecell"; > + reg = <0 0x20120000 0 0x1000>; > + > + clocks = <&soc_smc50mhz>; > + clock-names = "apb_pclk"; > + power-domains = <&scpi_devpd 0>; > > ports { > #address-cells = <1>; > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html