Re: [PATCH 2/2] ARM: dts: bcm283x: Add critical thermal zone for GPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Feb 07, 2017 at 08:19:31PM -0800, Eduardo Valentin wrote:
> On Sat, Feb 04, 2017 at 02:16:27PM +0000, Stefan Wahren wrote:
> > As suggested by Eduardo Valentin this adds the thermal zone for
> > the bcm2835 SoC. Since we currently don't have any cooling devices
> > leave this section empty.
> > 
> > Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
> > ---
> >  arch/arm/boot/dts/bcm283x.dtsi |   19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> > index 9c7ec7e..359da9d 100644
> > --- a/arch/arm/boot/dts/bcm283x.dtsi
> > +++ b/arch/arm/boot/dts/bcm283x.dtsi
> > @@ -19,6 +19,25 @@
> >  		bootargs = "earlyprintk console=ttyAMA0";
> >  	};
> >  
> > +	thermal-zones {
> > +		gpu_thermal: gpu-thermal {
> > +			polling-delay-passive = <0>;
> > +			polling-delay = <1000>;
> > +
> > +			thermal-sensors = <&thermal>;

Just came to my mind, dont you need to have an id to specify with sensor
points to gpu?

> > +
> > +			trips {
> > +				cpu-crit {
> > +					temperature	= <80000>;
> > +					hysteresis	= <0>;
> > +					type		= "critical";
> > +				};
> > +			};
> > +			cooling-maps {
> > +			};
> > +		};
> > +	};
> > +
> 
> This is fine with me. Checking the other patches in the series.
> 
> >  	soc {
> >  		compatible = "simple-bus";
> >  		#address-cells = <1>;
> > -- 
> > 1.7.9.5
> > 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux