On 02/01/2017 04:53 AM, Raju Lakkaraju wrote: > From: Raju Lakkaraju <Raju.Lakkaraju@xxxxxxxxxxxxx> > > LED Mode: > Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different > status information that can be selected by setting LED mode. Why is this LED selection done through Device Tree/initial configuration instead of coming up with a proper LED device registered by the PHY which allows you to select exactly how you want the modes to wind-up looking like? NB: you don't need a cover letter for single patches. > > LED Mode parameter (vsc8531, led-0-mode) and (vsc8531, led-1-mode) get from > Device Tree. > > Tested on Beaglebone Black with VSC 8531 PHY. > > Change set: > v0: > - Initial version of LED driver for Microsemi PHYs. > v1: > - Update all review comments given by Andrew. > - Add new header file "mscc-phy-vsc8531.h" to define DT macros. > - Add error/range check for DT LED mode input > v2: > - Fixed x86_64 build error. > > Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@xxxxxxxxxxxxx> > > > Raju Lakkaraju (1): > net: phy: Add LED mode driver for Microsemi PHYs. > > .../devicetree/bindings/net/mscc-phy-vsc8531.txt | 10 +++ > drivers/net/phy/mscc.c | 85 +++++++++++++++++++++- > include/dt-bindings/net/mscc-phy-vsc8531.h | 29 ++++++++ > 3 files changed, 123 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/net/mscc-phy-vsc8531.h > -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
