On Thu, 2017-01-19 at 11:05 +1100, Cyril Bur wrote: > > > +============ > > > +This represents the mailbox on the Soc. > > > + > > > +As the mailbox registers sit on the LPC bus, it makes most sense for > > > +the device to be within the LPC host node. See > > > +Documentation/devicetree/bindings/mfd/aspeed-lpc.txt for more > > > +information. This does not have to be the case, provided the reg > > > +property can give the full address of the mbox registers. > > > > This does have to be the case. I'd expect all devices on the LPC bus to > > be under a LPC bus node. > > > > Drop the last sentence, and: > > > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > > Will do, thanks for the review. Well well ... on the BMC side it's not actually on the LPC bus ;-) However it's within the LPC host controller register set, and so as such can be represented as a child of it. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html