On Wed, 2017-01-18 at 14:38 -0600, Rob Herring wrote: > On Thu, Jan 12, 2017 at 11:29:07AM +1100, Cyril Bur wrote: > > Signed-off-by: Cyril Bur <cyrilbur@xxxxxxxxx> > > --- > > .../devicetree/bindings/mailbox/aspeed-mbox.txt | 44 ++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mailbox/aspeed-mbox.txt > > > > diff --git a/Documentation/devicetree/bindings/mailbox/aspeed-mbox.txt b/Documentation/devicetree/bindings/mailbox/aspeed-mbox.txt > > new file mode 100644 > > index 000000000000..633cd534d91c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mailbox/aspeed-mbox.txt > > @@ -0,0 +1,44 @@ > > +ASpeed Mailbox Driver > > +===================== > > + > > +The ASpeed mailbox allows for communication between different > > +processors. The mailbox on the ASpeed ast2400 and ast2500 is a set of > > +16 single byte data registers along with interrupt and configuration > > +registers directly on the SoC. These are memory mapped on the aspeed > > +and can be accessed via the SuperIO registers on the other processor. > > + > > +Device Node: > > +============ > > +This represents the mailbox on the Soc. > > + > > +As the mailbox registers sit on the LPC bus, it makes most sense for > > +the device to be within the LPC host node. See > > +Documentation/devicetree/bindings/mfd/aspeed-lpc.txt for more > > +information. This does not have to be the case, provided the reg > > +property can give the full address of the mbox registers. > > This does have to be the case. I'd expect all devices on the LPC bus to > be under a LPC bus node. > > Drop the last sentence, and: > > Acked-by: Rob Herring <robh@xxxxxxxxxx> Will do, thanks for the review. Cyril -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
