Hi, On 19/01/17 14:53, Russell King - ARM Linux wrote: > On Thu, Jan 19, 2017 at 02:37:56PM +0000, Juri Lelli wrote: > > +extern unsigned long > > +arch_scale_cpu_capacity(struct sched_domain *sd, int cpu); > > +extern void set_capacity_scale(unsigned int cpu, unsigned long capacity); > > These should be in a header file (please run your code through sparse). > > > +extern bool cap_parsing_failed; > > +extern void normalize_cpu_capacity(void); > > +extern int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu); > > Same for these. > Right, I was wondering where to put these in the cover letter. New header file (e.g., include/linux/arch_topology.h) or some existing one? > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > > new file mode 100644 > > index 000000000000..3faf89518892 > > --- /dev/null > > +++ b/drivers/base/arch_topology.c > > @@ -0,0 +1,240 @@ > > +/* > > + * driver/base/arch_topology.c - Arch specific cpu topology information > > + * > > + * Written by: Juri Lelli, ARM Ltd. > > + * > > + * Copyright (C) 2016, ARM Ltd. > > + * > > + * All rights reserved. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Software Foundation; either version 2 of the License, or > > + * (at your option) any later version. > > The files that you've taken this code from are GPLv2, but you've thrown > a GPLv2+ header on a file that's merely a copy of the original code. > As some of the code you've moved to this new file is from Nicolas and > Vincent, you need to seek their approval to make this change of license > terms, or keep the original license terms. > Apologies. I'd say we keep the original one. I'll modify it in the next version. Thanks, - Juri -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
