Hi Linus, On Thu, Jan 19, 2017 at 12:09:37AM +0100, Linus Walleij wrote: > On Mon, Jan 16, 2017 at 2:24 PM, Maxime Ripard > <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > > > The ARM Mali Utgard GPU family is embedded into a number of SoCs from > > Allwinner, Amlogic, Mediatek or Rockchip. > > > > Add a binding for the GPU of that family. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/gpu/arm,mali-utgard.txt | 76 ++++++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt > > new file mode 100644 > > index 000000000000..df05ba0ec357 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt > > @@ -0,0 +1,76 @@ > > +ARM Mali Utgard GPU > > +=================== > > + > > +Required properties: > > + - compatible: > > + * "arm,mali-utgard" and one of the following: > > + + "arm,mali-300" > > + + "arm,mali-400" > > + + "arm,mali-450" > > + > > + - reg: Physical base address and length of the GPU registers > > + > > + - interrupts: an entry for each entry in interrupt-names. > > + See ../interrupt-controller/interrupts.txt for details. > > + > > + - interrupt-names: > > + * ppX: Pixel Processor X interrupt (X from 0 to 7) > > + * ppmmuX: Pixel Processor X MMU interrupt (X from 0 to 7) > > + * pp: Pixel Processor broadcast interrupt (mali-450 only) > > + * gp: Geometry Processor interrupt > > + * gpmmu: Geometry Processor MMU interrupt > > + > > + > > +Optional properties: > > + - interrupt-names: > > + * pmu: Power Management Unit interrupt, if implemented in hardware > > On the MALI-400 MP in the ST-Ericsson DB8500 we have an additional interrupt > called "Mali400 combined". This is simply the HW designer's > doing an OR over all the 4 IRQ lines. Is this useful to define in the > bindings? Then it should be an optional Do you still have all the other interrupts, or just this combined interrupt? Either way, that should definitely be part of the binding, but maybe as part of the vendor specific binding below? I didn't encounter any other platform doing so when I gave it a (quick) look. > * combined: all lines OR:ed together (if available) > > Also you are defining "resets" below in the examples, should > this be listed as an optional property? In my mind, this is not optional. For some platforms, it's mandatory, and for some, it's not there at all. IMO, this should really be a mandatory property, but only for the compatibles that use it (just like the clocks are). > > +The Mali GPU is integrated very differently from one SoC to > > +another. In order to accommodate those differences, you have the option > > +to specify one more vendor-specific compatible, among: > > + > > + - allwinner,sun4i-a10-mali > > + Required properties: > > + * clocks: an entry for each entry in clock-names > > + * clock-names: > > + + bus: bus clock for the GPU > > + + core: clock driving the GPU itself > > + * resets: phandle to the reset line for the GPU > > + > > + - allwinner,sun7i-a20-mali > > + Required properties: > > + * clocks: an entry for each entry in clock-names > > + * clock-names: > > + + bus: bus clock for the GPU > > + + core: clock driving the GPU itself > > + * resets: phandle to the reset line for the GPU > > Please add: > > - stericsson,db8500-mali: also known as the "Smart Graphics > Accelerator" (SGA500) > Required properties: > * clocks: an entry for each entry in clock-names > * clock-names: > + bus: bus clock for the GPU (ICNCLK a.k.a. PRCMU_ACLK) > + core: clock driving the GPU itself (PRCMU_SGACLK) > > (It has no explicit reset line.) Ack. > With these: > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
