Sorry all, appears some replies got stuck in my outbox and have just managed to send for some reason! Jonathan On 04/12/16 11:55, Jonathan Cameron wrote: > On 04/12/16 02:19, Brian Masney wrote: >> The isl29028 staging driver contains a legacy binding of "isl,isl29028" >> that is marked as legacy and to not use. There are no in tree references >> to that binding. This patch removes the legacy binding in preparation >> for moving the driver out of staging. Otherwise, we will have to support >> this binding indefinitely. > Leave this be. Given it exists there almost certainly device trees out there > using it. Lets not break them just to save on one line of code. > > Supporting legacy bindings isn't exactly costly! > > I'm happy with all the patches I haven't commented on. Just can't apply > them because they have dependencies on early patches that I have > raised questions on. > > Another generally nice bit of cleanup. > > Thanks, > > Jonathan >> >> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx> >> Cc: devicetree@xxxxxxxxxxxxxxx >> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >> Cc: Mark Rutland <Mark.Rutland@xxxxxxx> >> --- >> drivers/staging/iio/light/isl29028.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c >> index ae6896f..6be9aa7 100644 >> --- a/drivers/staging/iio/light/isl29028.c >> +++ b/drivers/staging/iio/light/isl29028.c >> @@ -611,7 +611,6 @@ static const struct i2c_device_id isl29028_id[] = { >> MODULE_DEVICE_TABLE(i2c, isl29028_id); >> >> static const struct of_device_id isl29028_of_match[] = { >> - { .compatible = "isl,isl29028", }, /* for backward compat., don't use */ >> { .compatible = "isil,isl29028", }, >> { }, >> }; >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html